Mercurial > hg > nginx-tests
view h2_proxy_max_temp_file_size.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 236d038dc04a |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Tests for http proxy module, proxy_max_temp_file_size directive. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::HTTP2; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http http_v2 proxy/)->plan(4); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% server { listen 127.0.0.1:8080 http2; server_name localhost; proxy_buffer_size 4k; proxy_buffers 8 4k; location / { proxy_max_temp_file_size 4k; proxy_pass http://127.0.0.1:8081/; } location /off/ { proxy_max_temp_file_size 0; proxy_pass http://127.0.0.1:8081/; } } server { listen 127.0.0.1:8081; server_name localhost; location / { } } } EOF $t->write_file('1', 'X' x (1024 * 1024)); # suppress deprecation warning open OLDERR, ">&", \*STDERR; close STDERR; $t->run(); open STDERR, ">&", \*OLDERR; ############################################################################### # test that the response is wholly proxied when all event pipe buffers are full my $s = Test::Nginx::HTTP2->new(); my $sid = $s->new_stream({ path => '/1' }); select undef, undef, undef, 0.4; $s->h2_window(1024 * 1024, $sid); $s->h2_window(1024 * 1024); my $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); my $body = join '', map { $_->{data} } grep { $_->{type} eq "DATA" } @$frames; like($body, qr/^X+$/m, 'no pipe bufs - body'); is(length($body), 1024 * 1024, 'no pipe bufs - body length'); # also with disabled proxy temp file $s = Test::Nginx::HTTP2->new(); $sid = $s->new_stream({ path => '/off/1' }); select undef, undef, undef, 0.4; $s->h2_window(1024 * 1024, $sid); $s->h2_window(1024 * 1024); $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); $body = join '', map { $_->{data} } grep { $_->{type} eq "DATA" } @$frames; like($body, qr/^X+$/m, 'no temp file - body'); is(length($body), 1024 * 1024, 'no temp file - body length'); ###############################################################################