Mercurial > hg > nginx-tests
view msie_refresh.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 05b2033f5377 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Test for msie_refresh. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http rewrite ssi/)->plan(5) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% server { listen 127.0.0.1:8080; server_name localhost; msie_refresh on; location / { return 301 text; } location /space { return 301 "space "; } location /error_page { return 301; error_page 301 text; } location /off { msie_refresh off; return 301 text; } location /ssi { ssi on; } } } EOF $t->write_file('ssi.html', 'X<!--#include virtual="/" -->X'); $t->run(); ############################################################################### like(get('/'), qr/Refresh.*URL=text"/, 'msie refresh'); like(get('/space'), qr/URL=space%20"/, 'msie refresh escaped url'); like(get('/error_page'), qr/URL=text"/, 'msie refresh error page'); unlike(get('/off'), qr/Refresh/, 'msie refresh disabled'); unlike(get('/ssi.html'), qr/^0\x0d\x0a?\x0d\x0a?\w/m, 'only final chunk'); ############################################################################### sub get { my ($url, $extra) = @_; return http(<<EOF); GET $url HTTP/1.1 Host: localhost Connection: close User-Agent: MSIE foo EOF } ###############################################################################