Mercurial > hg > nginx-tests
view stream_geo_binary.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | f3ba4c74de31 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Andrey Zelenkov # (C) Nginx, Inc. # Tests for stream geo module with binary base. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::Stream qw/ stream /; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; plan(skip_all => 'long configuration parsing') unless $ENV{TEST_NGINX_UNSAFE}; my $t = Test::Nginx->new()->has(qw/stream stream_return stream_geo/); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } stream { %%TEST_GLOBALS_STREAM%% geo $geo_base_create { ranges; include base.conf; } geo $geo_base_include { ranges; include base.conf; } server { listen 127.0.0.1:8080; return "geo_base_create:$geo_base_create geo_base_include:$geo_base_include"; } } EOF $t->write_file('base.conf', join('', map { "127." . $_/256/256 % 256 . "." . $_/256 % 256 . "." . $_ % 256 . "-127." . $_/256/256 % 256 . "." . $_/256 % 256 . "." .$_ % 256 . " " . ($_ == 1 ? "loopback" : "range$_") . ";" } (0 .. 100000))); $t->run()->plan(2); ############################################################################### my %data = stream('127.0.0.1:' . port(8080))->read() =~ /(\w+):(\w+)/g; is($data{geo_base_create}, 'loopback', 'geo binary base create'); is($data{geo_base_include}, 'loopback', 'geo binary base include'); ###############################################################################