Mercurial > hg > nginx-tests
view stream_upstream_zone.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | f3ba4c74de31 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Stream tests for upstream zone. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::Stream qw/ stream /; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/stream stream_return stream_upstream_zone/) ->plan(2)->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } stream { %%TEST_GLOBALS_STREAM%% log_format test $upstream_addr; upstream u { zone u 1m; server 127.0.0.1:8081; } upstream u2 { zone u; server 127.0.0.1:8081 down; server 127.0.0.1:8081 backup down; } server { listen 127.0.0.1:8081; return OK; } server { listen 127.0.0.1:8091; proxy_pass u; access_log %%TESTDIR%%/access1.log test; } server { listen 127.0.0.1:8092; proxy_pass u2; access_log %%TESTDIR%%/access2.log test; } } EOF $t->write_file('index.html', ''); $t->run(); ############################################################################### my $p = port(8081); stream('127.0.0.1:' . port(8091))->read(); stream("127.0.0.1:" . port(8092))->read(); $t->stop(); is($t->read_file('access1.log'), "127.0.0.1:$p\n", 'upstream name'); is($t->read_file('access2.log'), "u2\n", 'no live upstreams'); ###############################################################################