Mercurial > hg > nginx-tests
view upstream_least_conn.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 882267679006 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # Tests for upstream least_conn balancer module. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx qw/ :DEFAULT http_end /; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http proxy upstream_least_conn/)->plan(2); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% upstream u { least_conn; server 127.0.0.1:8081; server 127.0.0.1:8082; } server { listen 127.0.0.1:8080; server_name localhost; location / { proxy_pass http://u; } } } EOF $t->run_daemon(\&http_daemon, port(8081)); $t->run_daemon(\&http_daemon, port(8082)); $t->run(); $t->waitforsocket('127.0.0.1:' . port(8081)); $t->waitforsocket('127.0.0.1:' . port(8082)); ############################################################################### my @ports = my ($port1, $port2) = (port(8081), port(8082)); is(many('/', 10), "$port1: 5, $port2: 5", 'balanced'); my @sockets; push(@sockets, http_get('/w', start => 1)); push(@sockets, http_get('/w', start => 1)); select undef, undef, undef, 0.2; is(many('/w', 10), "$port2: 10", 'least conn'); ############################################################################### sub many { my ($uri, $count) = @_; my %ports; for (1 .. $count) { if (http_get($uri) =~ /X-Port: (\d+)/) { $ports{$1} = 0 unless defined $ports{$1}; $ports{$1}++; } } my @keys = map { my $p = $_; grep { $p == $_ } keys %ports } @ports; return join ', ', map { $_ . ": " . $ports{$_} } @keys; } ############################################################################### sub http_daemon { my ($port) = @_; my $server = IO::Socket::INET->new( Proto => 'tcp', LocalHost => '127.0.0.1', LocalPort => $port, Listen => 5, Reuse => 1 ) or die "Can't create listening socket: $!\n"; local $SIG{PIPE} = 'IGNORE'; while (my $client = $server->accept()) { $client->autoflush(1); my $headers = ''; my $uri = ''; while (<$client>) { $headers .= $_; last if (/^\x0d?\x0a?$/); } $uri = $1 if $headers =~ /^\S+\s+([^ ]+)\s+HTTP/i; if ($uri eq '/w' && $port == port(8081)) { Test::Nginx::log_core('||', "$port: sleep(2.5)"); select undef, undef, undef, 2.5; } Test::Nginx::log_core('||', "$port: response, 200"); print $client <<EOF; HTTP/1.1 200 OK Connection: close X-Port: $port OK EOF close $client; } } ###############################################################################