Mercurial > hg > nginx
annotate src/event/quic/ngx_event_quic_socket.h @ 9295:c5623963c29e
Upstream: fixed proxy_no_cache when caching errors.
Caching errors, notably intercepted errors and internally generated
502/504 errors, as well as handling of cache revalidation with 304,
did not take into account u->conf->no_cache predicates configured.
As a result, an error might be cached even if configuration explicitly
says not to. Fix is to check u->conf->no_cache in these cases.
To simplify usage in multiple places, checking u->conf->no_cache is now
done in a separate function. As a minor optimization, u->conf->no_cache
is only checked if u->cacheable is set.
As a side effect, this change also fixes caching errors after
proxy_cache_bypass. Also, during cache revalidation u->cacheable is
now tested, so 304 responses which disable caching won't extend
cacheability of stored responses.
Additionally, when caching internally generated 502/504 errors
u->cacheable is now explicitly updated from u->headers_in.no_cache and
u->headers_in.expired, restoring the behaviour before 8041:0784ab86ad08
(1.23.0) when an error happens while reading the response headers.
Reported by Kirill A. Korinsky,
https://freenginx.org/pipermail/nginx/2024-April/000082.html
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Tue, 25 Jun 2024 21:44:50 +0300 |
parents | c389200e10a2 |
children |
rev | line source |
---|---|
8763 | 1 |
2 /* | |
3 * Copyright (C) Nginx, Inc. | |
4 */ | |
5 | |
6 | |
7 #ifndef _NGX_EVENT_QUIC_SOCKET_H_INCLUDED_ | |
8 #define _NGX_EVENT_QUIC_SOCKET_H_INCLUDED_ | |
9 | |
10 | |
11 #include <ngx_config.h> | |
12 #include <ngx_core.h> | |
13 | |
14 | |
15 ngx_int_t ngx_quic_open_sockets(ngx_connection_t *c, | |
16 ngx_quic_connection_t *qc, ngx_quic_header_t *pkt); | |
17 void ngx_quic_close_sockets(ngx_connection_t *c); | |
18 | |
8955
32daba3aabb2
QUIC: got rid of ngx_quic_create_temp_socket().
Vladimir Homutov <vl@nginx.com>
parents:
8911
diff
changeset
|
19 ngx_quic_socket_t *ngx_quic_create_socket(ngx_connection_t *c, |
8763 | 20 ngx_quic_connection_t *qc); |
21 ngx_int_t ngx_quic_listen(ngx_connection_t *c, ngx_quic_connection_t *qc, | |
22 ngx_quic_socket_t *qsock); | |
23 void ngx_quic_close_socket(ngx_connection_t *c, ngx_quic_socket_t *qsock); | |
24 | |
25 ngx_quic_socket_t *ngx_quic_find_socket(ngx_connection_t *c, uint64_t seqnum); | |
26 | |
27 | |
28 #endif /* _NGX_EVENT_QUIC_SOCKET_H_INCLUDED_ */ |