Mercurial > hg > nginx

comparison src/event/quic/ngx_event_quic_socket.c @ 8911:b09f055daa4e quic

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
QUIC: fixed handling of RETIRE_CONNECTION_ID frame. Previously, the retired socket was not closed if it didn't match active or backup. New sockets could not be created (due to count limit), since retired socket was not closed before calling ngx_quic_create_sockets(). When replacing retired socket, new socket is only requested after closing old one, to avoid hitting the limit on the number of active connection ids. Together with added restrictions, this fixes an issue when a current socket could be closed during migration, recreated and erroneously reused leading to null pointer dereference.
author Vladimir Homutov <vl@nginx.com>
date Thu, 18 Nov 2021 14:19:36 +0300
parents 6d1488b62dc5
children aae8b91e0280
comparison
equal deleted inserted replaced
8910:f8848f5a1014 8911:b09f055daa4e
11 11
12 12
13 static ngx_int_t ngx_quic_create_temp_socket(ngx_connection_t *c, 13 static ngx_int_t ngx_quic_create_temp_socket(ngx_connection_t *c,
14 ngx_quic_connection_t *qc, ngx_str_t *dcid, ngx_quic_path_t *path, 14 ngx_quic_connection_t *qc, ngx_str_t *dcid, ngx_quic_path_t *path,
15 ngx_quic_client_id_t *cid); 15 ngx_quic_client_id_t *cid);
16
17 static void ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path);
18 16
19 17
20 ngx_int_t 18 ngx_int_t
21 ngx_quic_open_sockets(ngx_connection_t *c, ngx_quic_connection_t *qc, 19 ngx_quic_open_sockets(ngx_connection_t *c, ngx_quic_connection_t *qc,
22 ngx_quic_header_t *pkt) 20 ngx_quic_header_t *pkt)
205 "quic socket #%L closed nsock:%ui", 203 "quic socket #%L closed nsock:%ui",
206 (int64_t) qsock->sid.seqnum, qc->nsockets); 204 (int64_t) qsock->sid.seqnum, qc->nsockets);
207 } 205 }
208 206
209 207
210 static void 208 void
211 ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path) 209 ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path)
212 { 210 {
213 ngx_quic_connection_t *qc; 211 ngx_quic_connection_t *qc;
214 212
215 path->refcnt--; 213 path->refcnt--;