diff src/event/quic/ngx_event_quic_socket.c @ 8911:b09f055daa4e quic

QUIC: fixed handling of RETIRE_CONNECTION_ID frame. Previously, the retired socket was not closed if it didn't match active or backup. New sockets could not be created (due to count limit), since retired socket was not closed before calling ngx_quic_create_sockets(). When replacing retired socket, new socket is only requested after closing old one, to avoid hitting the limit on the number of active connection ids. Together with added restrictions, this fixes an issue when a current socket could be closed during migration, recreated and erroneously reused leading to null pointer dereference.
author Vladimir Homutov <vl@nginx.com>
date Thu, 18 Nov 2021 14:19:36 +0300
parents 6d1488b62dc5
children aae8b91e0280
line wrap: on
line diff
--- a/src/event/quic/ngx_event_quic_socket.c
+++ b/src/event/quic/ngx_event_quic_socket.c
@@ -14,8 +14,6 @@ static ngx_int_t ngx_quic_create_temp_so
     ngx_quic_connection_t *qc, ngx_str_t *dcid, ngx_quic_path_t *path,
     ngx_quic_client_id_t *cid);
 
-static void ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path);
-
 
 ngx_int_t
 ngx_quic_open_sockets(ngx_connection_t *c, ngx_quic_connection_t *qc,
@@ -207,7 +205,7 @@ ngx_quic_close_socket(ngx_connection_t *
 }
 
 
-static void
+void
 ngx_quic_unref_path(ngx_connection_t *c, ngx_quic_path_t *path)
 {
     ngx_quic_connection_t  *qc;