changeset 8766:70701edfc5d4 quic

HTTP/3: fixed decoder stream stubs. Now ngx_http_v3_ack_header() and ngx_http_v3_inc_insert_count() always generate decoder error. Our implementation does not use dynamic tables and does not expect client to send Section Acknowledgement or Insert Count Increment. Stream Cancellation, on the other hand, is allowed to be sent anyway. This is why ngx_http_v3_cancel_stream() does not return an error.
author Roman Arutyunyan <arut@nginx.com>
date Tue, 04 May 2021 13:38:59 +0300
parents 687445803d0f
children 33ec97749b5f
files src/http/v3/ngx_http_v3_tables.c
diffstat 1 files changed, 5 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/src/http/v3/ngx_http_v3_tables.c
+++ b/src/http/v3/ngx_http_v3_tables.c
@@ -390,9 +390,9 @@ ngx_http_v3_ack_header(ngx_connection_t 
     ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0,
                    "http3 ack header %ui", stream_id);
 
-    /* XXX */
+    /* we do not use dynamic tables */
 
-    return NGX_OK;
+    return NGX_HTTP_V3_ERR_DECODER_STREAM_ERROR;
 }
 
 
@@ -402,7 +402,7 @@ ngx_http_v3_cancel_stream(ngx_connection
     ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0,
                    "http3 cancel stream %ui", stream_id);
 
-    /* XXX */
+    /* we do not use dynamic tables */
 
     return NGX_OK;
 }
@@ -414,9 +414,9 @@ ngx_http_v3_inc_insert_count(ngx_connect
     ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0,
                    "http3 increment insert count %ui", inc);
 
-    /* XXX */
+    /* we do not use dynamic tables */
 
-    return NGX_OK;
+    return NGX_HTTP_V3_ERR_DECODER_STREAM_ERROR;
 }