Mercurial > hg > nginx

changeset 8371:9d9531431c8c quic

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Removed outdated/incorrect comments and fixed style. - we need transport parameters early to get packet size limits at least.
author Vladimir Homutov <vl@nginx.com>
date Wed, 29 Apr 2020 14:45:55 +0300
parents 262396242352
children 0e6528551f26
files src/event/ngx_event_quic.c src/event/ngx_event_quic.h src/event/ngx_event_quic_transport.h
diffstat 3 files changed, 7 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/src/event/ngx_event_quic.c
+++ b/src/event/ngx_event_quic.c
@@ -379,7 +379,6 @@ ngx_quic_add_handshake_data(ngx_ssl_conn
     ngx_log_debug0(NGX_LOG_DEBUG_EVENT, c->log, 0,
                    "quic ngx_quic_add_handshake_data");
 
-    /* XXX: obtain client parameters after the handshake? */
     if (!qc->client_tp_done) {
 
         SSL_get_peer_quic_transport_params(ssl_conn, &client_params,
@@ -1066,7 +1065,7 @@ ngx_quic_input(ngx_connection_t *c, ngx_
             break;
         }
 
-        // TODO: check current state
+        /* TODO: check current state */
         if (ngx_quic_long_pkt(pkt.flags)) {
 
             if (ngx_quic_pkt_in(pkt.flags)) {
@@ -1724,7 +1723,7 @@ ngx_quic_handle_ack_frame_range(ngx_conn
 
         ngx_log_error(NGX_LOG_INFO, c->log, 0,
                       "quic ACK for the packet not in sent queue ");
-        // TODO: handle error properly: PROTOCOL VIOLATION?
+        /* TODO: handle error properly: PROTOCOL VIOLATION */
         return NGX_ERROR;
     }
 
@@ -2578,7 +2577,6 @@ ngx_quic_free_frames(ngx_connection_t *c
 }
 
 
-/* pack a group of frames [start; end) into memory p and send as single packet */
 static ngx_int_t
 ngx_quic_send_frames(ngx_connection_t *c, ngx_queue_t *frames)
 {
--- a/src/event/ngx_event_quic.h
+++ b/src/event/ngx_event_quic.h
@@ -84,10 +84,10 @@ ngx_connection_t *ngx_quic_create_uni_st
 
 /********************************* DEBUG *************************************/
 
-//#define NGX_QUIC_DEBUG_PACKETS       /* dump packet contents */
-//#define NGX_QUIC_DEBUG_FRAMES        /* dump frames contents */
-//#define NGX_QUIC_DEBUG_FRAMES_ALLOC  /* log frames alloc/reuse/free */
-//#define NGX_QUIC_DEBUG_CRYPTO
+/* #define NGX_QUIC_DEBUG_PACKETS */      /* dump packet contents */
+/* #define NGX_QUIC_DEBUG_FRAMES */       /* dump frames contents */
+/* #define NGX_QUIC_DEBUG_FRAMES_ALLOC */ /* log frames alloc/reuse/free */
+/* #define NGX_QUIC_DEBUG_CRYPTO */
 
 #if (NGX_DEBUG)
 
--- a/src/event/ngx_event_quic_transport.h
+++ b/src/event/ngx_event_quic_transport.h
@@ -256,7 +256,7 @@ struct ngx_quic_frame_s {
         ngx_quic_path_challenge_frame_t         path_challenge;
         ngx_quic_path_challenge_frame_t         path_response;
     } u;
-    u_char                                      info[128]; // for debug
+    u_char                                      info[128]; /* for debug */
 };