Mercurial > hg > nginx

changeset 7192:d5a535774861

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
HTTP/2: finalize request as bad if parsing of pseudo-headers fails. This is in line when the required pseudo-headers are missing, and avoids spurious zero statuses in access.log.
author Ruslan Ermilov <ru@nginx.com>
date Tue, 30 Jan 2018 14:44:31 +0300
parents 61d276dcd493
children 9d14931cec8c
files src/http/v2/ngx_http_v2.c
diffstat 1 files changed, 1 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/src/http/v2/ngx_http_v2.c
+++ b/src/http/v2/ngx_http_v2.c
@@ -1583,14 +1583,7 @@ ngx_http_v2_state_process_header(ngx_htt
         }
 
         if (rc == NGX_DECLINED) {
-            if (ngx_http_v2_terminate_stream(h2c, h2c->state.stream,
-                                             NGX_HTTP_V2_PROTOCOL_ERROR)
-                == NGX_ERROR)
-            {
-                return ngx_http_v2_connection_error(h2c,
-                                                    NGX_HTTP_V2_INTERNAL_ERROR);
-            }
-
+            ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
             goto error;
         }