view proxy_cookie_flags.t @ 1961:fe6f22da53ec default tip

Tests: tests for usage of discarded body. The client_max_body_size limit should be ignored when the request body is already discarded. In HTTP/1.x, this is done by checking the r->discard_body flag when the body is being discarded, and because r->headers_in.content_length_n is 0 when it's already discarded. This, however, does not happen with HTTP/2 and HTTP/3, and therefore "error_page 413" does not work without relaxing the limit. Further, with proxy_pass, r->headers_in.content_length_n is used to determine length of the request body, and therefore is not correct if discarding of the request body isn't yet complete. While discarding the request body, r->headers_in.content_length_n contains the rest of the body to discard (or, in case of chunked request body, the rest of the current chunk to discard). Similarly, the $content_length variable uses r->headers_in.content_length if available, and also incorrect. The $content_length variable is used when proxying with fastcgi_pass, grpc_pass, and uwsgi_pass (scgi_pass uses the value calculated based on the actual request body buffers, and therefore works correctly).
author Maxim Dounin <mdounin@mdounin.ru>
date Sat, 27 Apr 2024 18:55:50 +0300
parents 5ac6efbe5552
children
line wrap: on
line source

#!/usr/bin/perl

# (C) Sergey Kandaurov
# (C) Nginx, Inc.

# Tests for the proxy_cookie_flags directive.

###############################################################################

use warnings;
use strict;

use Test::More;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()->has(qw/http proxy rewrite/);

$t->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

http {
    %%TEST_GLOBALS_HTTP%%

    server {
        listen       127.0.0.1:8080;
        server_name  localhost;

        location / {
            proxy_pass http://127.0.0.1:8081;

            proxy_cookie_flags a secure httponly samesite=none;
            proxy_cookie_flags b secure httponly samesite=lax;
            proxy_cookie_flags c secure httponly samesite=strict;
            proxy_cookie_flags d nosecure nohttponly nosamesite;

            proxy_cookie_flags $arg_complex secure;
            proxy_cookie_flags ~BAR httponly;

            location /off/ {
                proxy_pass http://127.0.0.1:8081;
                proxy_cookie_flags off;
            }
        }

        location /var/ {
            proxy_pass http://127.0.0.1:8081;
            proxy_cookie_flags $arg_v $arg_f1 $arg_f2 $arg_f3;
        }
    }

    server {
        listen       127.0.0.1:8081;
        server_name  localhost;

        location / {
            set $c "$arg_v$arg_complex=path=domain=; Domain=example.org$arg_f";
            add_header Set-Cookie $c;
            return 200 OK;
        }
    }
}

EOF

$t->run()->plan(14);

###############################################################################

is(http_get_set_cookie('/?v=a'),
	'a=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=None',
	'flags set all');
is(http_get_set_cookie('/?v=b'),
	'b=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=Lax',
	'flags set lax');
is(http_get_set_cookie('/?v=c'),
	'c=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=Strict',
	'flags set strict');

# edit already set flags

is(http_get_set_cookie('/?v=a&f=;Secure;HttpOnly;SameSite=Lax'),
	'a=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=None',
	'flags reset all');
is(http_get_set_cookie('/?v=b&f=;Secure;HttpOnly;SameSite=None'),
	'b=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=Lax',
	'flags reset lax');
is(http_get_set_cookie('/?v=c&f=;Secure;HttpOnly;SameSite=None'),
	'c=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=Strict',
	'flags reset strict');

is(http_get_set_cookie('/?v=d&f=;secure;httponly;samesite=lax'),
	'd=path=domain=; Domain=example.org',
	'flags remove');

is(http_get_set_cookie('/?v=nx&f=;samesite=none'),
	'nx=path=domain=; Domain=example.org;samesite=none', 'flags no match');

is(http_get_set_cookie('/?complex=v'),
	'v=path=domain=; Domain=example.org; Secure', 'flags variable');
is(http_get_set_cookie('/?v=foobarbaz'),
	'foobarbaz=path=domain=; Domain=example.org; HttpOnly', 'flags regex');

is(http_get_set_cookie('/off/?v=a'), 'a=path=domain=; Domain=example.org',
	'flags off');

# variables in flags

is(http_get_set_cookie('/var/?v=v&f1=secure&f2=httponly&f3=samesite=none'),
	'v=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=None',
	'flags set');
is(http_get_set_cookie('/var/?v=v&f=;Secure;HttpOnly;SameSite=Lax' .
	'&f1=secure&f2=httponly&f3=samesite=none'),
	'v=path=domain=; Domain=example.org; Secure; HttpOnly; SameSite=None',
	'flags reset');
is(http_get_set_cookie('/var/?v=v&f=;secure;httponly;samesite=lax' .
	'&f1=nosecure&f2=nohttponly&f3=nosamesite'),
	'v=path=domain=; Domain=example.org',
	'flags remove');

###############################################################################

sub http_get_set_cookie {
	my ($uri) = @_;
	http_get($uri) =~ /^Set-Cookie:\s(.+?)\x0d?$/mi;
	return $1;
}

###############################################################################