changeset 1356:ca6fe31f74c4

Tests: TODO grpc request body "first body bytes" test on FreeBSD. The test catches improper tcp_nopush usage, fixed in 8eab05b83dde.
author Sergey Kandaurov <pluknet@nginx.com>
date Mon, 09 Jul 2018 09:17:23 +0300
parents afe541649054
children 2415ef05a282
files grpc_request_buffering.t
diffstat 1 files changed, 12 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/grpc_request_buffering.t
+++ b/grpc_request_buffering.t
@@ -88,14 +88,23 @@ is($frame->{flags}, 1, 'request - DATA f
 ($frame) = grep { $_->{type} eq "HEADERS" } @$frames;
 is($frame->{headers}{'x-body'}, 'Hello', 'request body in memory');
 
-# expect body cleanup is disabled with preserve_output (ticket #1565).
-# after request body first bytes were proxied on behalf of initial window size,
-# send response header from upstream, this leads to body cleanup code path
+# tcp_nopush usage on peer connections
+# reopen window for request body after initial window was exhausted
+
+TODO: {
+local $TODO = 'not yet' if $t->read_file('nginx.conf') =~ /sendfile on/
+	and !$t->has_version('1.15.1') and $^O eq 'freebsd';
 
 $frames = $f->{http_start}('/proxy');
 is(eval(join '+', map { $_->{length} } grep { $_->{type} eq "DATA" } @$frames),
 	65535, 'preserve_output - first body bytes');
 
+}
+
+# expect body cleanup is disabled with preserve_output (ticket #1565).
+# after request body first bytes were proxied on behalf of initial window size,
+# send response header from upstream, this leads to body cleanup code path
+
 TODO: {
 local $TODO = 'not yet' unless $t->has_version('1.15.1');