Mercurial > hg > nginx

changeset 8358:2a6e91a1691d quic

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
TODOs cleanup in transport. We always generate stream frames that have length. The 'len' member is used during parsing incoming frames and can be safely ignored when generating output.
author Vladimir Homutov <vl@nginx.com>
date Thu, 23 Apr 2020 12:25:00 +0300
parents 05b8dd5d9f7e
children 2f900ae486bc
files src/event/ngx_event_quic_transport.c
diffstat 1 files changed, 1 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/src/event/ngx_event_quic_transport.c
+++ b/src/event/ngx_event_quic_transport.c
@@ -1267,15 +1267,6 @@ ngx_quic_create_stream(u_char *p, ngx_qu
     size_t   len;
     u_char  *start;
 
-    if (!sf->len) {
-#if 0
-        ngx_log_error(NGX_LOG_INFO, log, 0,
-                      "attempt to generate a stream frame without length");
-#endif
-        // XXX: handle error in caller
-        return NGX_ERROR;
-    }
-
     if (p == NULL) {
         len = ngx_quic_varint_len(sf->type);
 
@@ -1345,7 +1336,7 @@ ngx_quic_parse_transport_param(u_char *p
     case NGX_QUIC_TP_ORIGINAL_CONNECTION_ID:
     case NGX_QUIC_TP_STATELESS_RESET_TOKEN:
     case NGX_QUIC_TP_PREFERRED_ADDRESS:
-        // TODO
+        /* TODO: implement */
         return NGX_DECLINED;
     }